Skip to content

fix(toolkit-lib): unnecessary dependency on promptly #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 22, 2025

Fixes #396

This PR refactors the resource import prompts to use the IoHost instead. With that change, we can remove the promptly library as a toolkit-lib dependency and only have it in the CLI.

The change itself is not in a code path that is currently publicly available to toolkit-lib users, it only affects the cdk import command. The user experience for this is virtually unchanged, see screenshots.

Before:

image image image

After:

image image image

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 22, 2025 11:15
@github-actions github-actions bot added the p2 label May 22, 2025
@mrgrain mrgrain force-pushed the mrgrain/fix/toolkit-lib/no-promptly branch from e2a1007 to b4099b9 Compare May 22, 2025 11:21
@mrgrain mrgrain force-pushed the mrgrain/fix/toolkit-lib/no-promptly branch from b4099b9 to 224bcb5 Compare May 24, 2025 16:58
@mrgrain mrgrain temporarily deployed to integ-approval May 24, 2025 16:58 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.71%. Comparing base (841bc03) to head (52f9eec).

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/io-host/cli-io-host.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   78.72%   78.71%   -0.01%     
==========================================
  Files          46       46              
  Lines        6974     6977       +3     
  Branches      772      773       +1     
==========================================
+ Hits         5490     5492       +2     
- Misses       1465     1466       +1     
  Partials       19       19              
Flag Coverage Δ
suite.unit 78.71% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue May 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 26, 2025
@mrgrain mrgrain added this pull request to the merge queue May 26, 2025
Merged via the queue into main with commit 3d833d3 May 26, 2025
26 checks passed
@mrgrain mrgrain deleted the mrgrain/fix/toolkit-lib/no-promptly branch May 26, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove promptly from toolkit-lib
3 participants