-
Notifications
You must be signed in to change notification settings - Fork 35
fix(toolkit-lib): unnecessary dependency on promptly #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2a1007
to
b4099b9
Compare
b4099b9
to
224bcb5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
- Coverage 78.72% 78.71% -0.01%
==========================================
Files 46 46
Lines 6974 6977 +3
Branches 772 773 +1
==========================================
+ Hits 5490 5492 +2
- Misses 1465 1466 +1
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
224bcb5
to
52f9eec
Compare
rix0rrr
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396
This PR refactors the resource import prompts to use the IoHost instead. With that change, we can remove the promptly library as a toolkit-lib dependency and only have it in the CLI.
The change itself is not in a code path that is currently publicly available to toolkit-lib users, it only affects the
cdk import
command. The user experience for this is virtually unchanged, see screenshots.Before:
After:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license