Skip to content

fix(cloudformation-diff): @aws-sdk/client-cloudformation should be a peer dependency #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented May 8, 2025

The function signature of fullDiff depends on the DescribeChangeSetOutput type from @aws-sdk/client-cloudformation. Therefore this package should be a peer dependency, not a dev dependency.

Updates the dependency type, and adds the minimal version as a devDep to ensure we stay compatible. I needed to add 0BSD into the license checker since one of the transitive dependencies use it. It is an approved license.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 8, 2025 16:51
@github-actions github-actions bot added the p2 label May 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.18%. Comparing base (dbf44a8) to head (2df8cb7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files          54       54           
  Lines        6912     6912           
  Branches      772      773    +1     
=======================================
  Hits         5473     5473           
  Misses       1421     1421           
  Partials       18       18           
Flag Coverage Δ
suite.unit 79.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain temporarily deployed to integ-approval May 9, 2025 09:16 — with GitHub Actions Inactive
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 73994cf May 9, 2025
26 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/fix/cloudformation-diff-peer-dep branch May 9, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants