chore: reorg eslint rules into separate files #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Total lines changed 2553 is greater than 1000. Please consider breaking this PR down. |
mrgrain
commented
May 7, 2025
| @@ -99,7 +99,7 @@ export default class TestEnvironment extends NodeEnvironment implements JestEnvi | |||
| type TestDescription = PartialBy<Pick<Circus.TestEntry, 'name' | 'parent'>, 'parent'>; | |||
|
|
|||
| // Utility type to make specific fields optional | |||
| type PartialBy<T, K extends keyof T> = Omit<T, K> & Partial<Pick<T, K>> | |||
| type PartialBy<T, K extends keyof T> = Omit<T, K> & Partial<Pick<T, K>>; | |||
There was a problem hiding this comment.
This wasn't picked up before because the default eslint semi rules doesn't do TypeScript.
mrgrain
commented
May 7, 2025
| @@ -1,7 +1,7 @@ | |||
| /** | |||
| * @deprecated | |||
| */ | |||
| export type Obj<T> = {[key: string]: T}; | |||
| export type Obj<T> = { [key: string]: T }; | |||
There was a problem hiding this comment.
This wasn't picked up before because the default eslint key-spacing rules doesn't do TypeScript.
mrgrain
commented
May 7, 2025
| @@ -25,7 +25,7 @@ export function cached<A extends object, B>(obj: A, sym: symbol, fn: () => B): B | |||
| * @deprecated | |||
| */ | |||
| export interface ContextProviderPlugin { | |||
| getValue(args: {[key: string]: any}): Promise<any>; | |||
| getValue(args: { [key: string]: any }): Promise<any>; | |||
There was a problem hiding this comment.
This wasn't picked up before because the default eslint key-spacing rules doesn't do TypeScript.
mrgrain
force-pushed
the
mrgrain/chore/re-org-eslint
branch
from
cb48e59 to
5adcb38
Compare
iliapolo
approved these changes
May 7, 2025
Signed-off-by: github-actions <[email protected]>
aws-cdk-automation
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 54 54
Lines 6912 6912
Branches 773 773
=======================================
Hits 5473 5473
Misses 1421 1421
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
had a problem deploying
to
run-tests
GitHub Actions
Failure
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
run-tests
GitHub Actions
Inactive
|
pr/exempt-integ-test to bypass unrelated integ test failure. This PR does not require integ testing since no functional code is changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rules file got a bit large and hard to maintain/understand what's going on. In this change we are splitting the file up into sensible categories.
Also includes a projen upgrade to uses
@stylisticfor formatting rules and fixes a couple of rules to not use an array when they prefer to not use one (based on VSCode eslint plugin warnings). Places where some of the affected rules are disabled needed updating as well.There are a bunch of small formatting changes to type statements. These didn't get picked up previously because the built-in eslint rules don't support TypeScript, but the
@stylisticones do.The lack of any other changes to the codebase proves that these fixes are alright.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license