refactor(toolkit-lib): remove requireApproval option from diff
#372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
changed the title
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
changed the title
requireApproval option from diff
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
commented
Apr 21, 2025
| @@ -265,59 +260,4 @@ describe('formatSecurityDiff', () => { | |||
| '(NOTE: There may be security-related changes not in this list. See https://github.com/aws/aws-cdk/issues/1299)', | |||
| ); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
these tests don't make sense now that tmp-toolkit-helpers does not deal with approval levels at all
kaizencc
commented
Apr 21, 2025
| import { deserializeStructure, formatErrorMessage } from '../../../private/util'; | ||
|
|
||
| export function makeTemplateInfos( | ||
| export function prepareDiff( |
There was a problem hiding this comment.
fixing an oversight from before
kaizencc
commented
Apr 21, 2025
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requireApprovalis deprecated and has been moved to theCliIoHost. this PR removes the last place whererequireApprovalwas necessary intmp-toolkit-helpers, informatSecurityDiff.formatSecurityDiffnow makes no decisions on what to print; it returns the diff and apermissionChangeTypefor theIoHostto interpret. this is a slight behavior change, so all consumers offormatSecurityDiff have been updated accordingly (deployanddiffintoolkit-lib` and in the CLI).requireApprovalis now a vestigial structure only in use in the CLI.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license