Skip to content

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 6, 2025

Fixes #201

Feature request was for cli-lib-alpha, however we are instead adding this to the new package that should be used going forward.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 6, 2025 13:07
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (a3160a7) to head (4c363d8).
Report is 313 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   85.22%   85.34%   +0.12%     
==========================================
  Files         207      207              
  Lines       35706    35706              
  Branches     4632     4645      +13     
==========================================
+ Hits        30429    30472      +43     
+ Misses       5124     5079      -45     
- Partials      153      155       +2     
Flag Coverage Δ
suite.unit 85.34% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain force-pushed the mrgrain/feat/allow-skipping-assembly-validations branch from bdbf0b0 to bf480b1 Compare March 6, 2025 16:20
@mrgrain mrgrain marked this pull request as ready for review March 6, 2025 16:20
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 6, 2025
@mrgrain mrgrain force-pushed the mrgrain/feat/allow-skipping-assembly-validations branch from bf480b1 to 4c363d8 Compare March 6, 2025 17:22
@mrgrain mrgrain added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit 6e0b7f2 Mar 6, 2025
11 checks passed
@mrgrain mrgrain deleted the mrgrain/feat/allow-skipping-assembly-validations branch March 6, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request p2 pr/exempt-integ-test Skips the integ test steps if set.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(cli-lib-alpha): should be able to disable cloud assembly version check
3 participants