Skip to content

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Feb 26, 2025

Fixes another few issues with various publishing jobs:

  • Role chaining doesn't actually work with a session duration over one hour.
  • Also I realized none of these job actually take that long. This was a copy-and-paste fail from the integ-tests (which do take longer). So let's go back to a shorter duration for these jobs
  • Use different session names for all jobs
  • Consistently use mask-aws-account-id everywhere.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain force-pushed the mrgrain/chore/docs-publishing-assume-role branch from 01bcdf0 to ad101f2 Compare February 26, 2025 21:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (9873ff2) to head (d8705d4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   84.59%   84.58%   -0.02%     
==========================================
  Files         198      198              
  Lines       35380    35380              
  Branches     4547     4550       +3     
==========================================
- Hits        29931    29925       -6     
- Misses       5298     5308      +10     
+ Partials      151      147       -4     
Flag Coverage Δ
suite.unit 84.58% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrgrain mrgrain force-pushed the mrgrain/chore/docs-publishing-assume-role branch from ad101f2 to c3a2d8e Compare February 26, 2025 22:11
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Feb 26, 2025
@mrgrain mrgrain force-pushed the mrgrain/chore/docs-publishing-assume-role branch from c3a2d8e to d8705d4 Compare February 26, 2025 22:14
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit f9e65cb Feb 27, 2025
11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/chore/docs-publishing-assume-role branch February 27, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/exempt-integ-test Skips the integ test steps if set.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants