fix: replace poetry installation with bash for github actions #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanLeee
force-pushed
the
fix/pipelinePoetry
branch
2 times, most recently
from
a1cf54d to
6596e52
Compare
JuanLeee
commented
Jun 13, 2025
| with: | ||
| poetry-version: ${{ matrix.poetry-version }} | ||
| shell: bash | ||
| run: | |
There was a problem hiding this comment.
Why Use |?
Clarity: Even for a single command, using | makes it clear that the value is a multi-line string (and it’s a common convention in GitHub Actions).
Flexibility: If you later add more commands, you can do so without changing the YAML structure. For example:
7a85376 to
91c4708
Compare
JuanLeee
commented
Jun 13, 2025
| shell: bash | ||
| run: | | ||
| pipx install poetry==${{matrix.poetry-version}} | ||
| poetry config virtualenvs.prefer-active-python true |
There was a problem hiding this comment.
Not using the current python version installed causing all tests to run on python 3.12
There was a problem hiding this comment.
Can we add this comment directly to the workflow file for context
aaron-congo
approved these changes
Jun 13, 2025
JuanLeee
force-pushed
the
fix/pipelinePoetry
branch
from
91c4708 to
bfe18cf
Compare
karenc-bq
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
abatilo/actions-poetry#76
Known issue of poetry failing to install on ubuntu-latest
Changing installation to a bash command instead.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.