fix: statement cancel not working with mysql driver #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystall-bitquill
force-pushed
the
fix-cancel-statement
branch
3 times, most recently
from
e475195 to
452c28e
Compare
sergiyvamz
reviewed
Feb 1, 2024
wrapper/src/test/java/integration/container/tests/MysqlTests.java
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Feb 1, 2024
wrapper/src/main/java/software/amazon/jdbc/ConnectionPluginManager.java
Outdated
Show resolved
Hide resolved
crystall-bitquill
force-pushed
the
fix-cancel-statement
branch
2 times, most recently
from
893145b to
bc9b8ee
Compare
sergiyvamz
approved these changes
Feb 6, 2024
crystall-bitquill
force-pushed
the
fix-cancel-statement
branch
from
bc9b8ee to
452cc9c
Compare
karenc-bq
reviewed
Feb 7, 2024
crystall-bitquill
force-pushed
the
fix-cancel-statement
branch
2 times, most recently
from
fc910bc to
c3b4ff2
Compare
karenc-bq
reviewed
Feb 7, 2024
wrapper/src/test/java/software/amazon/jdbc/util/WrapperUtilsTest.java
Outdated
Show resolved
Hide resolved
karenc-bq
reviewed
Feb 7, 2024
| @@ -251,7 +260,9 @@ public static <T, E extends Exception> T executeWithPlugins( | |||
| } | |||
|
|
|||
| } finally { | |||
| pluginManager.unlock(); | |||
| if (lock.isHeldByCurrentThread()) { | |||
There was a problem hiding this comment.
I wonder if the unlock should happen after calling closeContext. Can you check with @sergiyvamz
|
|
||
| public class AsynchronousMethodsHelper { | ||
| public static final List<String> ASYNCHRONOUS_METHODS = Collections.singletonList( | ||
| "Statement.cancel" |
There was a problem hiding this comment.
What about other variations of statement.cancel? e.g. PreparedStatement.cancel
There was a problem hiding this comment.
Good point, it's been added to the list
crystall-bitquill
force-pushed
the
fix-cancel-statement
branch
from
c3b4ff2 to
61b3c1d
Compare
crystall-bitquill
force-pushed
the
fix-cancel-statement
branch
from
61b3c1d to
f2d7a06
Compare
jasonli-improving
pushed a commit
to Bit-Quill/aws-advanced-jdbc-wrapper
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Statement cancel not working with MySQL driver
Description
The Statement.cancel method currently does not function with the MySQL community driver due to locking the ConnectionPluginManager. The MySQL driver also synchronizes on the Statement.getConnection method, which blocks any Statement.cancel executions. This PR moves the lock location and skips executing Statement.getConnection when running Statement.cancel.
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.