-
Notifications
You must be signed in to change notification settings - Fork 69
add user documentation for DSQL plugin #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cf70258
to
96d089f
Compare
Update 96d089f adds references to the new docs/samples to the top-level documentation which I missed in the initial push. The diff for the example table update is a little messy because the table cells are not aligned on
|
96d089f
to
7f0d46e
Compare
Update to 7f0d46e changes the |
7f0d46e
to
71a809e
Compare
Change to 71a809e updates the wording around |
...erExample/src/main/java/software/amazon/AwsAuroraDsqlIamAuthenticationDatasourceExample.java
Show resolved
Hide resolved
71a809e
to
c79cadd
Compare
Update to c79cadd is a simple rebase, mostly to trigger CI jobs. |
docs/using-the-jdbc-driver/using-plugins/UsingTheDsqlAuthenticationPlugin.md
Show resolved
Hide resolved
...es/AWSDriverExample/src/main/java/software/amazon/AwsAuroraDsqlIamAuthenticationExample.java
Show resolved
Hide resolved
c79cadd
to
ebcf5d8
Compare
Update to ebcf5d8 improves some of the messaging in the main |
|
||
| Parameter | Value | Required | Description | Example Value | | ||
|-------------------|:-------:|:--------:|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------------------------------| | ||
| `iamHost` | String | No | This property will override the default hostname that is used to generate the IAM token. The default hostname is derived from the connection string. | `cluster-identifier.dsql.us-east-1.on.aws` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the conversation above where IP and Custom Endpoints are not accepted during connection, does it make sense to mention iamHost in the docs right now?
|-------------------|:-------:|:--------:|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------------------------------| | ||
| `iamHost` | String | No | This property will override the default hostname that is used to generate the IAM token. The default hostname is derived from the connection string. | `cluster-identifier.dsql.us-east-1.on.aws` | | ||
| `iamRegion` | String | No | This property will override the default region that is used to generate the IAM token. The default region is parsed from the connection string where possible. Some connection string formats may not be supported, and the `iamRegion` must be provided in these cases. | `us-east-2` | | ||
| `iamExpiration` | Integer | No | This property determines how long an IAM token is kept in the driver cache before a new one is generated. The default expiration time is set to be 14 minutes and 30 seconds. Note that IAM database authentication tokens have a lifetime of 15 minutes. | `600` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this accurate given DSQL allows you to set server sided token lifetime
|
||
// This file shows how to establish an Aurora DSQL connection using HikariCP datasource and the Aurora DSQL IAM | ||
// authentication plugin. | ||
public class AwsAuroraDsqlIamAuthenticationDatasourceExample { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of creating a new submodule for DSQL sample codes to reduce noise for DSQL customers
Summary
This PR adds user documentation and associated examples for using the AWS Aurora DSQL IAM authentication plugin.
This accompanies the change in #1477, which adds the
dsql
plugin implementation and tests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.