Skip to content

Fix/limitless dialect check + refactor synchronous router fetch #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 16, 2024
Merged

Fix/limitless dialect check + refactor synchronous router fetch #1148

merged 13 commits into from
Oct 16, 2024

Conversation

aaronchung-bitquill
Copy link
Contributor

@aaronchung-bitquill aaronchung-bitquill commented Oct 10, 2024 •
edited
Loading

Summary

Add checks for limitless dialect + refactor synchronous router fetch #1148

Description

  • added dialect checks in mulitple places.
  • new code path incase dialect is not right, and trying to resolve it
  • move limitless router endpoint fetching to a helper class LimitlessQueryHelper.
  • move synchronous fetch of limitless routers into service class
  • move router cache out of monitor and into service
  • add put method to SlidingExpirationCache
  • added a check in DialectManager specifically for PG Limitless to resolve to Aurora PG dialect

Additional Reviewers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aaronchung-bitquill aaronchung-bitquill force-pushed the fix/limitless-dialect-check branch from c002eb9 to fecb664 Compare October 10, 2024 18:00
sergiyvamz
sergiyvamz reviewed Oct 10, 2024
View reviewed changes
wrapper/src/main/java/software/amazon/jdbc/plugin/limitless/LimitlessConnectionPlugin.java Outdated
@@ -140,27 +157,29 @@ private Connection connectInternal(
LOGGER.finest(Messages.get("LimitlessConnectionPlugin.limitlessRouterCacheEmpty"));
final boolean waitForRouterInfo = WAIT_F0R_ROUTER_INFO.getBoolean(props);
if (waitForRouterInfo) {
limitlessRouters = synchronouslyGetLimitlessRoutersWithRetry(props);
limitlessRouters = synchronouslyGetLimitlessRoutersWithRetry(connectFunc.call(), hostSpec.getPort(), props);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if connectFunc.call() fails to connect?

@aaronchung-bitquill aaronchung-bitquill marked this pull request as ready for review October 11, 2024 16:10
@aaronchung-bitquill aaronchung-bitquill force-pushed the fix/limitless-dialect-check branch from 13606bc to 0459ead Compare October 15, 2024 17:19
@aaronchung-bitquill aaronchung-bitquill force-pushed the fix/limitless-dialect-check branch from 0459ead to d0f19e4 Compare October 15, 2024 17:20
@aaronchung-bitquill aaronchung-bitquill force-pushed the fix/limitless-dialect-check branch from d0f19e4 to 0524a8f Compare October 15, 2024 23:22
@aaronchung-bitquill aaronchung-bitquill force-pushed the fix/limitless-dialect-check branch from 0524a8f to 241db16 Compare October 16, 2024 00:12
@aaronchung-bitquill aaronchung-bitquill merged commit 7c5f391 into aws:main Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiyvamz sergiyvamz sergiyvamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronchung-bitquill @sergiyvamz