Skip to content

Conversation

@jaydeokar
Copy link
Collaborator

@jaydeokar jaydeokar commented Oct 2, 2025

What type of PR is this?
dependency

Which issue does this PR fix?: Multus operations fail if the plugins are missing

What does this PR do / Why do we need it?:
Multus does not install any plugins as a part of installation and expects these plugins to be present. AMI does not include these plugins today on AL23, so this cause Multus operations to fail starting v1.20.2 where we removed the unnecessary plugins.

Testing done on this change: N/A

Will this PR introduce any new dependencies?: Yes, it adds plugins which aren't directly used by VPC-CNI but by other meta plugins

Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No

Does this change require updates to the CNI daemonset config files to work?: No

Does this PR introduce any user-facing change?: No


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaydeokar jaydeokar requested a review from a team as a code owner October 2, 2025 18:56
Copilot AI review requested due to automatic review settings October 2, 2025 18:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the plugin fetching mechanism to include all CNI plugins instead of only a subset, addressing Multus operational failures due to missing plugins in AL23 AMI.

  • Removes the selective plugin copying approach and includes all available plugins
  • Updates the Makefile to copy all plugins from the built plugins directory

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jaydeokar jaydeokar marked this pull request as draft October 2, 2025 19:33
@jaydeokar jaydeokar marked this pull request as ready for review October 2, 2025 20:37
@jaydeokar jaydeokar merged commit 5c08a6f into aws:master Oct 2, 2025
7 checks passed
@jaydeokar jaydeokar added this to the v1.20.4 milestone Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants