Skip to content

Conversation

@jaydeokar
Copy link
Collaborator

@jaydeokar jaydeokar commented Aug 20, 2025

What type of PR is this?
dependency update and adds a automation to auto-generate vpc-limits.go file for new instances

Which issue does this PR fix?: golang CVE

What does this PR do / Why do we need it?: It uses the latest golang patch version instead of hard coding the patch release version

Testing done on this change: N/A

Will this PR introduce any new dependencies?: N/A

Will this break upgrades or downgrades? Has updating a running cluster been tested?: N/A

Does this change require updates to the CNI daemonset config files to work?: N/A

Does this PR introduce any user-facing change?: N/A


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copilot AI review requested due to automatic review settings August 20, 2025 01:03
@jaydeokar jaydeokar requested a review from a team as a code owner August 20, 2025 01:03

This comment was marked as outdated.

@jaydeokar jaydeokar force-pushed the go_version_update branch 3 times, most recently from 0912058 to 41d605b Compare August 21, 2025 21:29
@jaydeokar
Copy link
Collaborator Author

eg run - jaydeokar#14

@jaydeokar jaydeokar requested a review from Copilot August 21, 2025 21:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the pinning of specific Go patch versions to use the latest patch release automatically, addressing Go CVE security concerns. It also introduces automation to generate VPC IP resource limits for new AWS instance types.

Key changes include:

  • Updating Go version specification to use only major.minor version
  • Removing GOTOOLCHAIN export to allow automatic patch version selection
  • Adding GitHub Actions workflow for automated VPC limits generation

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
go.mod Updates Go version from 1.24.4 to 1.24.6
Makefile Removes GOTOOLCHAIN export to unpin patch versions
.go-version Changes from specific patch version 1.24.4 to major.minor 1.24
.github/workflows/generate-limits.yaml Adds new workflow for automated VPC limits generation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

viveksb007
viveksb007 previously approved these changes Aug 21, 2025
Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaydeokar jaydeokar merged commit 43928b1 into aws:master Aug 22, 2025
7 checks passed
@jaydeokar jaydeokar deleted the go_version_update branch August 22, 2025 19:13
jaydeokar added a commit that referenced this pull request Sep 18, 2025
* Bump github.com/samber/lo from 1.49.1 to 1.51.0 (#3386)

Bumps [github.com/samber/lo](https://github.com/samber/lo) from 1.49.1 to 1.51.0.
- [Release notes](https://github.com/samber/lo/releases)
- [Commits](samber/lo@v1.49.1...v1.51.0)

---
updated-dependencies:
- dependency-name: github.com/samber/lo
  dependency-version: 1.51.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/prometheus/client_model from 0.6.1 to 0.6.2 (#3385)

Bumps [github.com/prometheus/client_model](https://github.com/prometheus/client_model) from 0.6.1 to 0.6.2.
- [Release notes](https://github.com/prometheus/client_model/releases)
- [Commits](prometheus/client_model@v0.6.1...v0.6.2)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_model
  dependency-version: 0.6.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump the aws-dependencies group with 11 updates (#3384)

Bumps the aws-dependencies group with 11 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/aws/amazon-vpc-resource-controller-k8s](https://github.com/aws/amazon-vpc-resource-controller-k8s) | `1.7.4` | `1.7.5` |
| [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.36.5` | `1.37.1` |
| [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.29.17` | `1.30.2` |
| [github.com/aws/aws-sdk-go-v2/feature/ec2/imds](https://github.com/aws/aws-sdk-go-v2) | `1.16.32` | `1.18.1` |
| [github.com/aws/aws-sdk-go-v2/service/autoscaling](https://github.com/aws/aws-sdk-go-v2) | `1.54.0` | `1.55.1` |
| [github.com/aws/aws-sdk-go-v2/service/cloudformation](https://github.com/aws/aws-sdk-go-v2) | `1.61.0` | `1.62.1` |
| [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) | `1.45.3` | `1.46.1` |
| [github.com/aws/aws-sdk-go-v2/service/ec2](https://github.com/aws/aws-sdk-go-v2) | `1.233.0` | `1.239.0` |
| [github.com/aws/aws-sdk-go-v2/service/eks](https://github.com/aws/aws-sdk-go-v2) | `1.66.1` | `1.67.1` |
| [github.com/aws/aws-sdk-go-v2/service/iam](https://github.com/aws/aws-sdk-go-v2) | `1.43.0` | `1.44.1` |
| [github.com/aws/smithy-go](https://github.com/aws/smithy-go) | `1.22.4` | `1.22.5` |


Updates `github.com/aws/amazon-vpc-resource-controller-k8s` from 1.7.4 to 1.7.5
- [Release notes](https://github.com/aws/amazon-vpc-resource-controller-k8s/releases)
- [Commits](aws/amazon-vpc-resource-controller-k8s@v1.7.4...v1.7.5)

Updates `github.com/aws/aws-sdk-go-v2` from 1.36.5 to 1.37.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@v1.36.5...v1.37.1)

Updates `github.com/aws/aws-sdk-go-v2/config` from 1.29.17 to 1.30.2
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@config/v1.29.17...v1.30.2)

Updates `github.com/aws/aws-sdk-go-v2/feature/ec2/imds` from 1.16.32 to 1.18.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/v1.18.1/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@feature/ec2/imds/v1.16.32...v1.18.1)

Updates `github.com/aws/aws-sdk-go-v2/service/autoscaling` from 1.54.0 to 1.55.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.54.0...service/s3/v1.55.1)

Updates `github.com/aws/aws-sdk-go-v2/service/cloudformation` from 1.61.0 to 1.62.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.61.0...service/iot/v1.62.1)

Updates `github.com/aws/aws-sdk-go-v2/service/cloudwatch` from 1.45.3 to 1.46.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/rds/v1.45.3...service/ssm/v1.46.1)

Updates `github.com/aws/aws-sdk-go-v2/service/ec2` from 1.233.0 to 1.239.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/ec2/v1.233.0...service/ec2/v1.239.0)

Updates `github.com/aws/aws-sdk-go-v2/service/eks` from 1.66.1 to 1.67.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.66.1...service/s3/v1.67.1)

Updates `github.com/aws/aws-sdk-go-v2/service/iam` from 1.43.0 to 1.44.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.43.0...service/ecr/v1.44.1)

Updates `github.com/aws/smithy-go` from 1.22.4 to 1.22.5
- [Release notes](https://github.com/aws/smithy-go/releases)
- [Changelog](https://github.com/aws/smithy-go/blob/main/CHANGELOG.md)
- [Commits](aws/smithy-go@v1.22.4...v1.22.5)

---
updated-dependencies:
- dependency-name: github.com/aws/amazon-vpc-resource-controller-k8s
  dependency-version: 1.7.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aws-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-version: 1.37.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-version: 1.30.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/feature/ec2/imds
  dependency-version: 1.18.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/autoscaling
  dependency-version: 1.55.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudformation
  dependency-version: 1.62.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch
  dependency-version: 1.46.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/ec2
  dependency-version: 1.239.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/eks
  dependency-version: 1.67.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-dependencies
- dependency-name: github.com/aws/aws-sdk-go-v2/service/iam
  dependency-version: 1.44.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-dependencies
- dependency-name: github.com/aws/smithy-go
  dependency-version: 1.22.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aws-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Adding release notes and chart update (#3399)

* updating tags (#3400)

* Add and configure soak tests workflow (#3404)

* Add and configure soak tests workflow

* Update soak tests workflow

* Add and configure soak tests workflow (#3407)

* Bump actions/checkout from 4.1.7 to 5.0.0 (#3409)

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 5.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@692973e...08c6903)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump helm.sh/helm/v3 from 3.18.4 to 3.18.5 (#3401)

Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.18.4 to 3.18.5.
- [Release notes](https://github.com/helm/helm/releases)
- [Commits](helm/helm@v3.18.4...v3.18.5)

---
updated-dependencies:
- dependency-name: helm.sh/helm/v3
  dependency-version: 3.18.5
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Removing pinning of golang version (#3411)

* Bump the k8s-dependencies group across 1 directory with 5 updates (#3359)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-version: 0.33.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-version: 0.33.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/cli-runtime
  dependency-version: 0.33.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-version: 0.33.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-version: 0.21.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: update VPC IP resource limits (#3419)

Co-authored-by: jaydeokar <[email protected]>

* chore: update VPC IP resource limits (#3420)

Co-authored-by: jaydeokar <[email protected]>

* Fetch only necessary plugins (#3416)

* chore: update VPC IP resource limits (#3422)

Co-authored-by: jaydeokar <[email protected]>

* chore: update VPC IP resource limits (#3438)

Co-authored-by: jaydeokar <[email protected]>

* Move npagent server port to unix socket (#3442)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yash Thakkar <[email protected]>
Co-authored-by: Supreeth <[email protected]>
Co-authored-by: Jay Deokar <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants