Updating static config for instances and better error handling #3378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haouc
reviewed
Jul 30, 2025
haouc
previously approved these changes
Jul 30, 2025
jaydeokar
commented
Jul 30, 2025
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Which issue does this PR fix?:
Missing static config for instances which are no longer publicly available
What does this PR do / Why do we need it?:
We have a fallback to describe the instance in case we don't have the data, but that fails here
Testing done on this change: N/A
Will this PR introduce any new dependencies?: N/A
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
N/A
Does this change require updates to the CNI daemonset config files to work?: N/A
Does this PR introduce any user-facing change?: N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.