Skip to content

Conversation

kessplas
Copy link
Contributor

@kessplas kessplas commented May 15, 2025

Issue #, if available:

Description of changes:

The async client does not support "low-level" multipart uploads via CreateMPU/UploadPart/CompleteMPU. However, these APIs are accessible through the delegate client, which is misleading. This change overrides the unsupported operations and throws exceptions accordingly.

This MAY break some customers, however, it is safer that way as otherwise objects are uploaded in plaintext.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@kessplas kessplas marked this pull request as ready for review May 15, 2025 21:38
@kessplas kessplas requested a review from a team as a code owner May 15, 2025 21:38
Copy link
Contributor

@imabhichow imabhichow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imabhichow imabhichow merged commit 599f941 into main May 16, 2025
14 checks passed
@imabhichow imabhichow deleted the disable-async-low-level-mpu branch May 16, 2025 21:56
rishav-karanjit pushed a commit that referenced this pull request May 20, 2025
## [3.3.5](v3.3.4...v3.3.5) (2025-05-20)

### Fixes

* determine effective contentLength, account for tagLength on decrypt ([#463](#463)) ([969d721](969d721))
* disable low-level Multipart Upload in Async client ([#461](#461)) ([599f941](599f941))
* support PutObjectResponse fields ([#462](#462)) ([dec503b](dec503b))
josecorella pushed a commit that referenced this pull request May 21, 2025
## [3.3.5](v3.3.4...v3.3.5) (2025-05-21)

### Fixes

* determine effective contentLength, account for tagLength on decrypt ([#463](#463)) ([969d721](969d721))
* disable low-level Multipart Upload in Async client ([#461](#461)) ([599f941](599f941))
* support PutObjectResponse fields ([#462](#462)) ([dec503b](dec503b))

### Maintenance

* Revert "Amazon S3 Encryption Client 3.3.5 Release -- 2025-05-20" ([#465](#465)) ([3f9ac8e](3f9ac8e))
* update dependency needed for semantic-release  ([#464](#464)) ([0fd3b58](0fd3b58))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants