fix: handle S3 server encoding of non-US-ASCII object metadata #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/java/software/amazon/encryption/s3/S3EncryptionClientTestVectorsTest.java
Show resolved
Hide resolved
lucasmcdonald3
approved these changes
Sep 26, 2024
josecorella
pushed a commit
that referenced
this pull request
Oct 4, 2024
## [3.2.3](v3.2.2...v3.2.3) (2024-10-04) ### Fixes * catch CompletionException instead when instruction file is not found ([#379](#379)) ([dd61547](dd61547)) * handle S3 server encoding of non-US-ASCII object metadata ([#375](#375)) ([b907743](b907743)) * introduce S3-specific client configuration to top-level configuration ([#378](#378)) ([54fa0cb](54fa0cb)) ### Maintenance * fix release cfn and codebuild ([#380](#380)) ([2844498](2844498)) * fix release javadocs ([#373](#373)) ([8a69959](8a69959))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
See aws/amazon-s3-encryption-client-go#56 for more details.
The AWS SDK for Java v2 does not allow use of non-US-ASCII characters. However, since it is the most fully-featured and widely-used implementation of the S3 Encryption Client, it should be able to decrypt ciphertexts which other clients can write.
This PR adds support for reading/decrypting messages which have non-US-ASCII characters in the encryption context/material description by decoding the S3 server's unique encoding scheme.
This PR also adds a simple "test vector" bucket which contains static ciphertexts to decrypt as part of integration testing, as the Java client cannot write the ciphertexts that it can now decrypt.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: