Skip to content

Conversation

kessplas
Copy link
Contributor

Issue #, if available: #165

Description of changes: Unwraps completion exception thrown from AbortMultipartUpload in the default client, and in the uploadPart calls within "high-level" multipart putObject.

The latter is not tested, because the API surface does not allow for (convenient) testing.

see #167 for previous discussion.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@kessplas kessplas requested a review from a team as a code owner August 18, 2023 23:17
Copy link
Contributor

@imabhichow imabhichow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kessplas kessplas merged commit 84baad8 into main Aug 21, 2023
@kessplas kessplas deleted the exception-unwrap-mpu branch August 21, 2023 18:14
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Aug 31, 2023
## [3.1.0](v3.0.1...v3.1.0) (2023-08-31)

### Features

* add configuration option to set max buffer size ([#166](#166)) ([ecf6e6c](ecf6e6c))
* multipart & ranged get examples ([#168](#168)) ([203e5dc](203e5dc))
* Refactor `KmsKeyring` to use `GenerateDataKey` instead of `Encrypt` ([#171](#171)) ([a1a22a4](a1a22a4))

### Fixes

* Create default wrapped clients only if necessary. ([#163](#163)) ([285eab6](285eab6))
* unwrap completion exception in AbortMultipartUpload and inside multipart putObject ([#174](#174)) ([84baad8](84baad8))

### Maintenance

* allow CI to run in forks ([#164](#164)) ([66a5ca4](66a5ca4))
* **deps-dev:** bump bcprov-jdk18on from 1.72 to 1.74 ([#169](#169)) ([5502eab](5502eab))
* fix bugs and nit ([#175](#175)) ([926818b](926818b))
* install dependabot ([#172](#172)) ([1c63fdb](1c63fdb))
* warn against use of Encryption Context for non-kms keyrings. ([#173](#173)) ([54557a9](54557a9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants