Create AES Keyring and skeleton of S3 client #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
requested changes
Jun 8, 2022
There was a problem hiding this comment.
I have lots of questions from this PR...
I probably am under-informed about what the S3EC specification is.
If it supports multiple EDKs, then things here will not work as is.
If it does not, then this is really close, but we need to stop using lists of EDKs.
I'll see if I can grab time on your calendar tomorrow to sync about this all.
src/main/java/software/amazon/encryption/s3/algorithms/AlgorithmSuite.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/encryption/s3/materials/MaterialsManager.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/encryption/s3/materials/EncryptionMaterials.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/encryption/s3/materials/EncryptionMaterials.java
Show resolved
Hide resolved
src/main/java/software/amazon/encryption/s3/materials/DecryptionMaterialsRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/encryption/s3/S3EncryptionClient.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/encryption/s3/materials/AESKeyring.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/encryption/s3/materials/AESKeyring.java
Outdated
Show resolved
Hide resolved
texastony
requested changes
Jun 10, 2022
src/main/java/software/amazon/encryption/s3/materials/AESKeyring.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/encryption/s3/materials/AESKeyring.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/encryption/s3/materials/DefaultDataKeyGenerator.java
Show resolved
Hide resolved
src/main/java/software/amazon/encryption/s3/materials/AESKeyring.java
Outdated
Show resolved
Hide resolved
* Allow AESKeyring to take a `SecureRandom` parameter. * Remove 'what' comments from AESKeyring. * Rename algorithm suite name to match spec. * Rename decrypt materials function to match spec.
imabhichow
added a commit
that referenced
this pull request
Aug 17, 2022
Consolidate metadata strategy
akareddy04
added a commit
that referenced
this pull request
Jul 14, 2025
Amazon S3 Encryption Client 3.3.5 Release -- 2025-05-20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add an AES keyring that is compatible with S3 encryption client. Add skeleton S3 client
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.