Skip to content

handle the null case for contentType in adt plugin environment #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

handle the null case for contentType in adt plugin environment #496

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3c3c0f
handle the null case for contentType in adt plugin environment
XiaoxuanLu Aug 8, 2025
c5341d6
Merge branch 'feature/adt-support' into xiaoluk/adt-support
XiaoxuanLu Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugin/src/software/aws/toolkits/eclipse/amazonq/util/QEclipseEditorUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,9 @@ public static IQInlineTypeaheadProcessor getAutoCloseSettings(final ITextEditor
if (input instanceof FileEditorInput) {
IFile file = ((FileEditorInput) input).getFile();
IContentType contentType = Platform.getContentTypeManager().findContentTypeFor(file.getName());
contentTypeName = contentType.getName();
if (contentType != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiousity do you know why content type is null for abap files?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched and it said that this commonly happens with files that don't have recognized extensions or aren't registered with Eclipse's content type system. I think we do not register in Eclipse's content type systems. I will check if there is some place that I can add them

contentTypeName = contentType.getName();
}
}
if (contentTypeName == null) {
return new GenericTypeheadProcessor();
Expand Down