-
Notifications
You must be signed in to change notification settings - Fork 237
Refactor AWS NVMe Scraper for Easier Device Extensibility #1817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7f5bd0
to
80f8394
Compare
jefchien
reviewed
Aug 12, 2025
80f8394
to
5988b17
Compare
e47046e
to
b6dabc2
Compare
jefchien
reviewed
Aug 14, 2025
b6dabc2
to
c96f14e
Compare
f2b2f2b
to
a38f64e
Compare
zhihonl
previously approved these changes
Aug 15, 2025
jefchien
reviewed
Aug 15, 2025
5cd8d79
to
8f317ea
Compare
8f317ea
to
46a8df8
Compare
jefchien
approved these changes
Aug 18, 2025
zhihonl
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the awsnvmereceiver by introducing the DeviceInfoProvider interface to abstract device-specific operations. The scraper now interacts with NVMe devices through this interface instead of hardcoded switch logic, making it easier to add new device types, improve testability, and maintain the code.
Interface Description:
In order to add a new nvme device we would just need to implement this interface and we should be able to get those nvme metrics.
Testing
Manually tested and was able to get metrics:
