fix(thumbor): allow watermarks in folders for thumbor requests #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thumbor style requests including a watermark in a folder failed with watermark key not found error.
The parseImageKey regex failed to detect the watermark key correctly due to the embedded slash.
This changes the regex to detect the watermark correctly and includes new unit tests for that case.
Example thumbor style request with watermark in folder/key.png:
/fit-in/400x400/filters:watermark(bucket,folder/key.png,0,0)/image.jpg
Description of changes:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.