fix random test failure due to thread not finishing #91
Conversation
| @@ -371,27 +371,6 @@ TEST_CASE( "Test destination mode", "[destination]") { | |||
| { | |||
| return (msg.type() == com::amazonaws::iot::securedtunneling::Message_Type_STREAM_RESET) && msg.streamid() == 1; | |||
There was a problem hiding this comment.
is it possible that the reason of this test failure is that we have reset the stream? maybe process did not have enough time between resetting stream and creating new connection.
| @@ -371,27 +371,6 @@ TEST_CASE( "Test destination mode", "[destination]") { | |||
| { | |||
| return (msg.type() == com::amazonaws::iot::securedtunneling::Message_Type_STREAM_RESET) && msg.streamid() == 1; | |||
| }); | |||
| destination_socket.close(); | |||
There was a problem hiding this comment.
should we wait until we get acknowledgement from the destination LP that the stream is reset now before closing the connection?
on which line did we see the failure?
There was a problem hiding this comment.
https://github.com/aws-samples/aws-iot-securetunneling-localproxy/blob/master/test/AdapterTests.cpp#L384
this line was originally causing failure
There was a problem hiding this comment.
I tried put tcp_accept_thread.join(); before REQUIRE( accepted ); and it stucks there, seems that tcp_accept_thread.join(); never finished and join back
There was a problem hiding this comment.
and that is not consistent, sometimes it passes sometimes it sits there got stuck
Motivation
Modifications
Change summary
Using
conditional_variableto hold the main thread until the supporting thread is finishedRevision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.