fix(build): remove esbuild and use tsc for the compilation #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @walmsles thanks for the PR (and sorry for the delay)! If you could resolve the merge conflicts, I'd be happy to merge it right away. |
- Remove esbuild.config.mjs and related dependencies - Update package.json build scripts to use tsc - Simplify build process for better compatibility
No delay - it is Open Source 🥇 and have been doing more important tasks (sorry for making lots of work for you)
👍 All done - I rebased main onto my PR and pushed it up |
dreamorosi
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Remove use of
esbuildand use tsc to simplify the build process.This PR resolves the issue described in #61 by removing esbuild. This is a required simplification that removes the
esbuildissue for the server runtime. This PR should replace PR #71 as a preferred alternative.note: This PR should not be included until #72 has bee resolved since e2e tests are essential for moving forward.
Issue number:
#61
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.