-
Notifications
You must be signed in to change notification settings - Fork 159
docs(theme): upgrade mkdocs material to 8.x #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one small comment. Please ping me in Slack after it's answered/addressed and I can approve.
.gitignore
Outdated
@@ -36,6 +36,7 @@ venv | |||
|
|||
# Static documentation site generated by Mkdocs | |||
site | |||
!docs/overrides/*.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need an override to be included in git. Is it being ignored somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it really needs to be in this file, a comment would be useful for future contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, remove it in the latest commit.
Description of your changes
This PR updates MKDocs (the documentation engine we use) and adds the necessary extension to add annotations on code (no annotation added at this time). The PR mirrors this commit from the Python's repo.
How to verify this change
Checkout repo & build docs locally.
Related issues, RFCs
N/A
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.