Skip to content

docs(theme): upgrade mkdocs material to 8.x #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2022

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR updates MKDocs (the documentation engine we use) and adds the necessary extension to add annotations on code (no annotation added at this time). The PR mirrors this commit from the Python's repo.

How to verify this change

Checkout repo & build docs locally.

Related issues, RFCs

N/A

PR status

Is this ready for review?: NO
Is it a breaking change?: NO

Checklist

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added documentation Improvements or additions to documentation dependencies Changes that touch dependencies, e.g. Dependabot, etc. labels Feb 4, 2022
@dreamorosi dreamorosi added this to the production-ready-release milestone Feb 4, 2022
@dreamorosi dreamorosi self-assigned this Feb 4, 2022
saragerion
saragerion previously approved these changes Feb 7, 2022
Copy link
Contributor

@saragerion saragerion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM already

@dreamorosi dreamorosi requested a review from saragerion February 9, 2022 14:43
@dreamorosi dreamorosi marked this pull request as ready for review February 9, 2022 14:44
Copy link
Contributor

@ijemmy ijemmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one small comment. Please ping me in Slack after it's answered/addressed and I can approve.

.gitignore Outdated
@@ -36,6 +36,7 @@ venv

# Static documentation site generated by Mkdocs
site
!docs/overrides/*.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need an override to be included in git. Is it being ignored somewhere else?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it really needs to be in this file, a comment would be useful for future contributors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, remove it in the latest commit.

@dreamorosi dreamorosi requested a review from ijemmy February 11, 2022 17:30
@dreamorosi dreamorosi requested a review from flochaz February 15, 2022 09:24
@dreamorosi dreamorosi merged commit 18228d5 into main Feb 15, 2022
@dreamorosi dreamorosi deleted the docs/theme/upgrade_mkdocs-material_to_8.x branch February 15, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants