refactor(tracer): replace class-based env access with functional helpers #4146
+52
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
tests
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
|
Hi @chetan9518 thank you for opening this PR! I'll review it soon, in the meantime could you please leave a comment on the linked issue, so that I can assign it to you? GitHub doesn't allow me to assign issues if you haven't interacted with it first. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the legacy class-based
EnvironmentVariablesServicefrom the Tracer package and replaces it with functionalgetEnvhelpers from@aws-lambda-powertools/commons.Changes
EnvironmentVariablesServiceclassgetEnv,getXRayTraceIdFromEnv)EnvironmentVariablesService.test.ts(no longer needed)Issue number: #4137
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.