Skip to content

docs(all): do not generate main version #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

ijemmy
Copy link
Contributor

@ijemmy ijemmy commented Jan 5, 2022

Description of your changes

We are generating dev version in on-merge-to-main.yml.

This part of the script isn't needed anymore as we agree to use dev version instead of main. The current code is also in the wrong place (in on-release-prod.yml). This will cause us to generate main every time we release.

How to verify this change

Rerun release workflow manually! So we can't test it. But the change is simple enough to be safe.

Related issues, RFCs

N/A

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ijemmy ijemmy changed the title docs(all): do not generate main version anymore docs(all): do not generate main version Jan 5, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 5, 2022
@saragerion saragerion merged commit eedbc7f into main Jan 5, 2022
@saragerion saragerion deleted the feat/switchToUseDevInDoc branch January 5, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants