Skip to content

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR adds a new environment scope to the release workflows so that the npm token used to make releases can be accessed only by said workflows.

Related issues, RFCs

Issue number: #1956

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from a team January 25, 2024 10:22
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Jan 25, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jan 25, 2024
@dreamorosi dreamorosi self-assigned this Jan 25, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sthulb sthulb merged commit 8c7286e into main Jan 25, 2024
@sthulb sthulb deleted the chore/scope_release_token branch January 25, 2024 10:23
@dreamorosi dreamorosi linked an issue Jan 25, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: update npm token for release
2 participants