-
Notifications
You must be signed in to change notification settings - Fork 159
improv(commons): add number key type to JSONObject type #1715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Kudos, SonarCloud Quality Gate passed!
|
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
Hi @KhurramJalil thanks for opening this issue. The PR is being labeled as
### Related issues, RFCs
<!---
Add here the number (i.e. #42) to the Github Issue or RFC that is related to this PR.
Don't include any other text, otherwise the Github Issue will not be detected.
Note: If no issue is present the PR might get blocked and not be reviewed.
-->
**Issue number:** The issue number should have gone near ### Related issues, RFCs
<!---
Add here the number (i.e. #42) to the Github Issue or RFC that is related to this PR.
Don't include any other text, otherwise the Github Issue will not be detected.
Note: If no issue is present the PR might get blocked and not be reviewed.
-->
-- **Issue number:**
++ **Issue number:** closes #1689
Once the issues above have been fixed I'll be happy to approve & merge the PR 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KhurramJalil thanks again for the PR, please review the comment above and let me know if you need any additional help.
Thanks for your kind review and feedback @dreamorosi. I have taken care of both the feedback points.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing all the comments, I've made a small edit to the title to remove the content of the old one.
Other than that, it's good to go. Congrats on your first PR merged in this project 🎉
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Fixes #1689
Description of your changes
Related issues, RFCs
Issue number: closes #1689
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.