Skip to content

fix(logger): wait for decorated method return before clearing out state #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2022
Merged

fix(logger): wait for decorated method return before clearing out state #1087

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6deb00
fix: await decorated method
dreamorosi Sep 11, 2022
e1f8790
chore: housekeeping
dreamorosi Sep 19, 2022
a0e07fb
chore: add unit test case
dreamorosi Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/logger/src/Logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ class Logger extends Utility implements ClassThatLogs {
const loggerRef = this;
// Use a function() {} instead of an () => {} arrow function so that we can
// access `myClass` as `this` in a decorated `myClass.myMethod()`.
descriptor.value = (function (this: Handler, event, context, callback) {
descriptor.value = (async function (this: Handler, event, context, callback) {

let initialPersistentAttributes = {};
if (options && options.clearState === true) {
Expand All @@ -297,7 +297,7 @@ class Logger extends Utility implements ClassThatLogs {
/* eslint-disable @typescript-eslint/no-non-null-assertion */
let result: unknown;
try {
result = originalMethod!.apply(this, [ event, context, callback ]);
result = await originalMethod!.apply(this, [ event, context, callback ]);
} catch (error) {
throw error;
} finally {
Expand Down