Feature request: Increase maximum number of metrics dimension from 10 to 30

[ijemmy]

Summary

Increase maximum number of metrics dimension from 10 to 30

Bug description

CloudWatch Metrics has increase maximum number of dimensions from 10 to 30 ref.

Currently, metrics utility throws an error when user try to add more than 10 dimension. This should be updated to 30.

Note: Powertools for Python is having the same change in this issue. Note that we DO NOT consider this as breaking change. (See that issue discussion on this)

Expected Behavior

Clients should be able to add up to 30 dimensions before throwing an error.

Current Behavior

Adding more than 10 dimensions will throw an error.

Possible Solution

You can find the relevant code to update in this search.

Required changes are:

1. Update MAX_DIMENSION_COUNT variable from 9 to 29
2. Update related unit tests

Steps to Reproduce

Call metrics.addDimension() more then 10 times. See this test case for example.

Environment

• Powertools version used: all
• Packaging format (Layers, npm): npm
• AWS Lambda function runtime: all runtimes
• Debugging logs: n/a

Related issues, RFCs

• Issue with the same change in Python

[sthuber90]

Happy to take over this task

[dreamorosi]

Hi @sthuber90 thanks for commenting under the issue.

Based on the description above the change should involve both the Metric class & unit tests, not sure yet about integration tests. Do you need any additional info/support in defining the scope of the feature?

I'll assign the issue to you and I'll be happy to help with reviewing the PR once it's opened.

[sthuber90]

Thank you very much. I will try to work out a minimal PR and look into whether integration tests make sense for this feature. All in all, it really seems like a good first issue and easy to start with :)

[github-actions]

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.