fix(license): correction to MIT + MIT-0 (no proprietary anymore)

[e42sh]

Poetry generates license classifiers based on a licenses.json@b5d1934.

At the moment MIT-0 is not recognized as an existing license and a Classifier: License :: Other/Proprietary License is added to the list of classifiers which leads to unexpected behavior from license checkers.

Signed-off-by: Martin [email protected]

Issue number:

Maintenance: Add header to LICENSE #1881

Summary

Changes

Updated poetry configuration.

User experience

License checkers should not complain about proprietary licenses. PyPi will signal a MIT and MIT-0 license instead of the proprietary license.

See current state:

Source https://pypi.org/project/aws-lambda-powertools/

The resulting PKG-INFO should look like

# PKG-INFO
Metadata-Version: 2.1
Name: aws-lambda-powertools
Version: 2.7.0
Summary: A suite of utilities for AWS Lambda functions to ease adopting best practices such as tracing, structured logging, custom metrics, batching, idempotency, feature flags, and more.
Home-page: https://github.com/awslabs/aws-lambda-powertools-python
License: MIT
...
Classifier: License :: OSI Approved :: MIT License
Classifier: License :: OSI Approved :: MIT No Attribution License (MIT-0)
...

Checklist

If your change doesn't seem to apply, please leave them unchecked.

• Meet tenets criteria
• I have performed a self-review of this change
• Changes have been tested
• Changes are documented
• PR title follows conventional commit semantics

Is this a breaking change?

Yes. The PKG-INFO in the distribution package will change. The Classifier: License :: Other/Proprietary License classifier will be removed and besides the Classifier: License :: OSI Approved :: MIT License classifier an additional License :: OSI Approved :: MIT No Attribution License (MIT-0) will be added through the use of trove_classifiers.

However, from my point of view, it should match with other distributions of the Lambda Power Tools, e.g. https://www.npmjs.com/package/@aws-lambda-powertools/metrics and should not raise any issues from other users, as the license becomes more relaxed.

However, when Poetry / Poetry Core will support MIT-0, this breaking change would implicitly occur without any notification.

RFC issue number:

Checklist:

• Migration process documented
• Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[heitorlessa]

This is a stellar contribution - thank you for linking the Poetry findings. Merging, and will be making a patch release within the next hour or so.

[codecov-commenter]

Codecov Report

Base: 97.51% // Head: 97.51% // No change to project coverage 👍

Coverage data is based on head (192f5de) compared to base (3314893).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1883   +/-   ##
========================================
  Coverage    97.51%   97.51%           
========================================
  Files          143      143           
  Lines         6570     6570           
  Branches       466      466           
========================================
  Hits          6407     6407           
  Misses         128      128           
  Partials        35       35           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.