fix(kafka): Add support for confluent message indices. #1902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
leandrodamascena
approved these changes
Jun 19, 2025
github-project-automation
bot
moved this from Pending review
to Coming soon
in Powertools for AWS Lambda (Java)
Comment on lines
+87
to
+89
| for (int i = 0; i < firstValue; i++) { | ||
| codedInputStream.readUInt32(); // Skip each message index value | ||
| } |
There was a problem hiding this comment.
This will clip multiple bytes which might be part of the actual data as well. We have seen cases for confluent serialized proto messages where first byte is not the length but index of the message
There was a problem hiding this comment.
Thanks. I will update to reading varint and also handle Glue bytes as an additional edge-case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1901
Description of changes:
This is an import fix to support customers using Confluent schema integration on the producer side of Protobuf messages. This only applies for Protobuf and not for Avro.
According to the wire format of the Confluent serializers message-indices are injected as additional bytes after magic bytes and schema id:
magic-byte, schema-id, message-indexes, protobuf-payload
We need to strip these message-indexes before attempting to parse the data using the plain Google protobuf library. This is what this PR is doing:
Added unit tests covering 100% of branches.
Checklist