Skip to content

chore: Remove version check from execution environment #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

chore: Remove version check from execution environment #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3d5218
test: update assertions to use Assert.Contains for environment variab…
hjgraca Apr 8, 2025
941de66
Merge branch 'develop' into fix/execution-env-ignore-version
hjgraca Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ests/AWS.Lambda.Powertools.BatchProcessing.Tests/Internal/BatchProcessingInternalTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public void BatchProcessing_Set_Execution_Environment_Context_SQS()
var sqsBatchProcessor = new SqsBatchProcessor(conf);

// Assert
Assert.Equal($"{Constants.FeatureContextIdentifier}/BatchProcessing/{env.GetAssemblyVersion(this)}",
Assert.Contains($"{Constants.FeatureContextIdentifier}/BatchProcessing/",
env.GetEnvironmentVariable("AWS_EXECUTION_ENV"));

Assert.NotNull(sqsBatchProcessor);
Expand All @@ -52,7 +52,7 @@ public void BatchProcessing_Set_Execution_Environment_Context_Kinesis()
var KinesisEventBatchProcessor = new KinesisEventBatchProcessor(conf);

// Assert
Assert.Equal($"{Constants.FeatureContextIdentifier}/BatchProcessing/{env.GetAssemblyVersion(this)}",
Assert.Contains($"{Constants.FeatureContextIdentifier}/BatchProcessing/",
env.GetEnvironmentVariable("AWS_EXECUTION_ENV"));

Assert.NotNull(KinesisEventBatchProcessor);
Expand All @@ -69,7 +69,7 @@ public void BatchProcessing_Set_Execution_Environment_Context_DynamoDB()
var dynamoDbStreamBatchProcessor = new DynamoDbStreamBatchProcessor(conf);

// Assert
Assert.Equal($"{Constants.FeatureContextIdentifier}/BatchProcessing/{env.GetAssemblyVersion(this)}",
Assert.Contains($"{Constants.FeatureContextIdentifier}/BatchProcessing/",
env.GetEnvironmentVariable("AWS_EXECUTION_ENV"));

Assert.NotNull(dynamoDbStreamBatchProcessor);
Expand Down
2 changes: 1 addition & 1 deletion libraries/tests/AWS.Lambda.Powertools.Idempotency.Tests/Internal/IdempotentAspectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ public void Idempotency_Set_Execution_Environment_Context()
var xRayRecorder = new Idempotency(conf);

// Assert
Assert.Equal($"{Constants.FeatureContextIdentifier}/Idempotency/{env.GetAssemblyVersion(this)}",
Assert.Contains($"{Constants.FeatureContextIdentifier}/Idempotency/",
env.GetEnvironmentVariable("AWS_EXECUTION_ENV"));

Assert.NotNull(xRayRecorder);
Expand Down
2 changes: 1 addition & 1 deletion libraries/tests/AWS.Lambda.Powertools.Logging.Tests/PowertoolsLoggerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1369,7 +1369,7 @@ public void Log_Set_Execution_Environment_Context()
logger.LogInformation("Test");

// Assert
Assert.Equal($"{Constants.FeatureContextIdentifier}/Logging/{env.GetAssemblyVersion(this)}",
Assert.Contains($"{Constants.FeatureContextIdentifier}/Logging/",
env.GetEnvironmentVariable("AWS_EXECUTION_ENV"));
}

Expand Down
2 changes: 1 addition & 1 deletion libraries/tests/AWS.Lambda.Powertools.Metrics.Tests/MetricsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public void Metrics_Set_Execution_Environment_Context()
_ = new Metrics(conf);

// Assert
Assert.Equal($"{Constants.FeatureContextIdentifier}/Metrics/{env.GetAssemblyVersion(this)}",
Assert.Contains($"{Constants.FeatureContextIdentifier}/Metrics/",
env.GetEnvironmentVariable("AWS_EXECUTION_ENV"));
}

Expand Down
2 changes: 1 addition & 1 deletion libraries/tests/AWS.Lambda.Powertools.Tracing.Tests/XRayRecorderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public void Tracing_Set_Execution_Environment_Context()
var xRayRecorder = new XRayRecorder(awsXray, conf);

// Assert
Assert.Equal($"{Constants.FeatureContextIdentifier}/Tracing/{env.GetAssemblyVersion(this)}",
Assert.Contains($"{Constants.FeatureContextIdentifier}/Tracing/",
env.GetEnvironmentVariable("AWS_EXECUTION_ENV"));

Assert.NotNull(xRayRecorder);
Expand Down
Loading