chore: add partition to acktest identity functions #708
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/test acktest-s3-e2e-tests |
|
tested in aws-controllers-k8s/s3-controller#173 |
|
/retest |
1 similar comment
|
/retest |
| def get_partition() -> str: | ||
| return boto3.client('sts').get_caller_identity().get('Arn').split(':')[1] |
There was a problem hiding this comment.
how about using botocore.arn/parse_arn https://github.com/boto/botocore/blob/develop/botocore/utils.py#L2136
There was a problem hiding this comment.
I did see that..it just requires us to have a new dependency in requirements.txt just to get partition from an arn.
I am willing to add it if you think its best
There was a problem hiding this comment.
I thought we already have a botocore dependency ( I think boto3 already depends on botocore)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.