Skip to content

feat(cli): no-docker CLI switch #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 25, 2022

Conversation

mmaeng
Copy link
Contributor

@mmaeng mmaeng commented Nov 18, 2022

Closes #89

Add in no-docker CLI switch command to correspond with the opposite use-docker CLI switch.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 98.54% // Head: 98.56% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (510a5f3) compared to base (0b9ef64).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   98.54%   98.56%   +0.01%     
==========================================
  Files          14       14              
  Lines        1239     1250      +11     
  Branches      207      209       +2     
==========================================
+ Hits         1221     1232      +11     
  Misses         17       17              
  Partials        1        1              
Flag Coverage Δ
unittests 98.56% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/rpdk/typescript/codegen.py 98.75% <100.00%> (+0.07%) ⬆️
python/rpdk/typescript/parser.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@ericzbeard ericzbeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need both? Isn't it redundant?

@mmaeng
Copy link
Contributor Author

mmaeng commented Nov 23, 2022

The use-docker and no-docker corresponds to
sam build --use-container and just sam build commands using CLI options.

If you don't specify either one it will go into interactive mode to ask which you would want to use.

@mmaeng mmaeng requested a review from kddejong November 23, 2022 21:31
@mmaeng mmaeng merged commit d72144a into aws-cloudformation:master Nov 25, 2022
@mmaeng mmaeng deleted the feat/nodocker branch November 25, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-docker switch on CLI
3 participants