-
Notifications
You must be signed in to change notification settings - Fork 15
feat(CI): add MacOS CI testing #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 98.54% // Head: 98.54% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 14 14
Lines 1239 1239
Branches 209 207 -2
=======================================
Hits 1221 1221
Misses 17 17
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
SAM CLI v.1.47 is needed to support colima (alternative to docker engine, which cannot be used because of licensing) on MacOS. SAM v1.47.0 is not compatible with Python 3.6 and Python 3.6 was removed from the testing suite. |
MacOS - docker and colima on Github Runners SAM Colima Support v1.47.0 SAM deprecate Python 3.6 in v1.42 |
# Ensure colima is configured for later user | ||
echo "DOCKER_HOST=unix://$HOME/.colima/default/docker.sock" >> $GITHUB_ENV | ||
# Verify Docker | ||
docker ps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hows this verify docker? Seems like extra and for logging purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to do a docker CLI to server connection check.
docker info
docker version
would also be options that fail if docker CLI cannot connect with the backend. Though those are more verbose.
Closes #85
Run CI testing on MacOS to help ensure no breaking changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.