Skip to content

feat(CI): add MacOS CI testing #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 23, 2022
Merged

Conversation

mmaeng
Copy link
Contributor

@mmaeng mmaeng commented Nov 11, 2022

Closes #85

Run CI testing on MacOS to help ensure no breaking changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 98.54% // Head: 98.54% // No change to project coverage 👍

Coverage data is based on head (42be90e) compared to base (9671098).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          14       14           
  Lines        1239     1239           
  Branches      209      207    -2     
=======================================
  Hits         1221     1221           
  Misses         17       17           
  Partials        1        1           
Flag Coverage Δ
unittests 98.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mmaeng
Copy link
Contributor Author

mmaeng commented Nov 11, 2022

SAM CLI v.1.47 is needed to support colima (alternative to docker engine, which cannot be used because of licensing) on MacOS. SAM v1.47.0 is not compatible with Python 3.6 and Python 3.6 was removed from the testing suite.

@mmaeng
Copy link
Contributor Author

mmaeng commented Nov 11, 2022

MacOS - docker and colima on Github Runners
actions/runner-images#17

SAM Colima Support v1.47.0
aws/aws-sam-cli#3595

SAM deprecate Python 3.6 in v1.42
https://github.com/aws/aws-sam-cli/releases/tag/v1.42.0

# Ensure colima is configured for later user
echo "DOCKER_HOST=unix://$HOME/.colima/default/docker.sock" >> $GITHUB_ENV
# Verify Docker
docker ps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hows this verify docker? Seems like extra and for logging purposes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to do a docker CLI to server connection check.
docker info
docker version

would also be options that fail if docker CLI cannot connect with the backend. Though those are more verbose.

@mmaeng mmaeng merged commit 0b9ef64 into aws-cloudformation:master Nov 23, 2022
@mmaeng mmaeng deleted the fix/issue85 branch November 23, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI tests are not being run on MacOS
3 participants