Skip to content

feat(cli): Add in typescript language along with use-docker switch into the CLI #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 26, 2022

Conversation

mmaeng
Copy link
Contributor

@mmaeng mmaeng commented Oct 24, 2022

May help with Issue #62 as well

This allows "typescript" and "--use-docker" or "-d" to be chosen directly in the CLI without going through the interactive menus.
Bringing the typescript plugin more in line with python plugin

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 98.53% // Head: 98.54% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c8ab2e1) compared to base (b33ceba).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   98.53%   98.54%           
=======================================
  Files          13       14    +1     
  Lines        1232     1237    +5     
  Branches      209      207    -2     
=======================================
+ Hits         1214     1219    +5     
  Misses         17       17           
  Partials        1        1           
Flag Coverage Δ
unittests 98.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/rpdk/typescript/codegen.py 98.65% <100.00%> (ø)
python/rpdk/typescript/parser.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@ericzbeard ericzbeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about all the any warnings? Should we disable that in PR validation, or edit the PR?

@kddejong
Copy link
Contributor

What about all the any warnings? Should we disable that in PR validation, or edit the PR?

@ericzbeard you talking about Unchanged files with check annotations Beta section? I got tripped up on that too but I think that is safe to ignore now since its unrelated to his changes.

@mmaeng mmaeng merged commit 09a0561 into aws-cloudformation:master Oct 26, 2022
@mmaeng mmaeng deleted the typescript-cli branch October 26, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sub parsers for Java, TypeScript, C#
3 participants