-
Notifications
You must be signed in to change notification settings - Fork 15
Update to Node.js 14.x runtime #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Node.js 14.x runtime #51
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 98.93% 99.09% +0.16%
==========================================
Files 13 13
Lines 1215 1210 -5
Branches 212 206 -6
==========================================
- Hits 1202 1199 -3
+ Misses 13 11 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Howdy! With Node.js 12.x deprecation looming, what are the chances of getting this (and hopefully #67) merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but could you plz address warnings
Looks good to me but there are bunch of warning, Could you fix this warning: Unexpected any. Specify a different type |
I would propose for us to merge this as is, because I will not have the time to address all the warnings at this moment. A refactor is required to fix all the linting issues. |
closing as this is a dup of #71 |
Issue #, if available:
Description of changes: Update to Node.js 14.x runtime
Related to issue: aws-cloudformation/cloudformation-cli#746
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.