Skip to content

Update to Node.js 14.x runtime #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eduardomourar
Copy link
Contributor

@eduardomourar eduardomourar commented Apr 30, 2021

Issue #, if available:

Description of changes: Update to Node.js 14.x runtime

Related to issue: aws-cloudformation/cloudformation-cli#746

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #51 (3fe13db) into master (ddcfb54) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   98.93%   99.09%   +0.16%     
==========================================
  Files          13       13              
  Lines        1215     1210       -5     
  Branches      212      206       -6     
==========================================
- Hits         1202     1199       -3     
+ Misses         13       11       -2     
Flag Coverage Δ
unittests 99.09% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/rpdk/typescript/codegen.py 100.00% <100.00%> (ø)
src/resource.ts 99.17% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddcfb54...3fe13db. Read the comment docs.

@RichiCoder1
Copy link

Howdy! With Node.js 12.x deprecation looming, what are the chances of getting this (and hopefully #67) merged?

Copy link
Contributor

@ammokhov ammokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but could you plz address warnings

@gsurbhi
Copy link

gsurbhi commented Jul 12, 2022

Looks good to me but there are bunch of warning, Could you fix this warning: Unexpected any. Specify a different type

@eduardomourar
Copy link
Contributor Author

I would propose for us to merge this as is, because I will not have the time to address all the warnings at this moment. A refactor is required to fix all the linting issues.

@duncangrant duncangrant mentioned this pull request Aug 5, 2022
@ammokhov
Copy link
Contributor

ammokhov commented Aug 5, 2022

closing as this is a dup of #71

@ammokhov ammokhov closed this Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants