Skip to content

Codegen change & Version Bump #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2021

Conversation

ammokhov
Copy link
Contributor

@ammokhov ammokhov commented Apr 8, 2021

Issue #, if available:

Description of changes:

Codegen change & plugin version bump

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #47 (a9504a5) into master (1eeffd7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   98.93%   98.93%   -0.01%     
==========================================
  Files          13       13              
  Lines        1218     1215       -3     
  Branches      212      212              
==========================================
- Hits         1205     1202       -3     
  Misses         13       13              
Flag Coverage Δ
unittests 98.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/rpdk/typescript/__init__.py 100.00% <100.00%> (ø)
python/rpdk/typescript/codegen.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eeffd7...a9504a5. Read the comment docs.

@ammokhov ammokhov merged commit 4a03d0b into aws-cloudformation:master Apr 8, 2021
@ammokhov ammokhov deleted the plugin-version-bump branch April 8, 2021 23:20
SUPPORT_LIB_NAME = (
"@amazon-web-services-cloudformation/cloudformation-cli-typescript-lib"
)
SUPPORT_LIB_VERSION = "^1.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Now that the package will be published to NPM, the version here will only need to be changed for a major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants