Skip to content

Add new properties for resource request #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2020

Conversation

eduardomourar
Copy link
Contributor

Issue #, if available:

Description of changes:

Additional properties to BaseResourceHandlerRequest class:

  • desiredResourceTags
  • previousResourceTags
  • systemTags
  • awsAccountId
  • region
  • awsPartition

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #23 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   97.49%   97.50%   +0.01%     
==========================================
  Files          13       13              
  Lines         877      881       +4     
  Branches      154      157       +3     
==========================================
+ Hits          855      859       +4     
  Misses         22       22              
Flag Coverage Δ
#unittests 97.50% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/proxy.ts 95.74% <ø> (-0.75%) ⬇️
src/resource.ts 94.59% <ø> (ø)
src/interface.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c14e0...501dcf4. Read the comment docs.

@eduardomourar eduardomourar merged commit f50e602 into master Aug 30, 2020
@eduardomourar eduardomourar deleted the feature/add-request-properties branch August 30, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant