Fix casting from empty string to number or boolean #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardomourar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 97.47% 97.49% +0.02%
==========================================
Files 13 13
Lines 870 877 +7
Branches 148 154 +6
==========================================
+ Hits 848 855 +7
Misses 22 22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eduardomourar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #12
Description of changes: This will cast to a number or boolean considering the case where an empty string is sent by CloudFormation.