Skip to content

Improve error logging #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 25, 2020
Merged

Conversation

eduardomourar
Copy link
Contributor

@eduardomourar eduardomourar commented May 9, 2020

Issue #, if available: #10

Description of changes:

Fix bug where error message was not appearing in CloudWatch and improve error logging to help investigate underlying service issues.

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #11 into master will increase coverage by 0.56%.
The diff coverage is 82.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   94.26%   94.83%   +0.56%     
==========================================
  Files          13       13              
  Lines         837      871      +34     
  Branches      124      136      +12     
==========================================
+ Hits          789      826      +37     
+ Misses         48       45       -3     
Flag Coverage Δ
#unittests 94.83% <82.08%> (+0.56%) ⬆️
Impacted Files Coverage Δ
src/utils.ts 83.05% <ø> (-1.33%) ⬇️
src/resource.ts 95.04% <73.33%> (-1.37%) ⬇️
src/log-delivery.ts 93.25% <82.97%> (+5.33%) ⬆️
python/rpdk/typescript/__init__.py 100.00% <100.00%> (ø)
python/rpdk/typescript/codegen.py 100.00% <100.00%> (ø)
src/callback.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f879739...4e4309d. Read the comment docs.

@eduardomourar eduardomourar merged commit e32021c into master May 25, 2020
@eduardomourar eduardomourar deleted the feature/0010-improve-error-logging branch May 25, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant