Optimize rule filtering performance #4222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pre-compute enabled rules set once at start of Rules.run() - Use fast set lookup instead of repeated is_rule_enabled() calls - Add enabled_rule_ids parameter to run_check() method - Reduces config property access calls from thousands to hundreds - Achieves ~32% performance improvement on large templates Fixes performance bottleneck where is_rule_enabled() was called for every match generated, causing excessive config property access through _get_argument_value().
kddejong
force-pushed
the
optimize-rule-filtering
branch
from
36d3d89 to
4cd4caa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4222 +/- ##
==========================================
- Coverage 94.50% 94.48% -0.03%
==========================================
Files 411 411
Lines 13948 13955 +7
Branches 2764 2767 +3
==========================================
+ Hits 13182 13185 +3
- Misses 422 425 +3
- Partials 344 345 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fixes performance bottleneck where is_rule_enabled() was called for every match generated, causing excessive config property access through _get_argument_value().
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.