Skip to content

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Jul 23, 2025

Issue #

Update the minimum supported macOS version to match the AWS SDK for Swift.

Description

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner July 23, 2025 20:11
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:12 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:13 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:13 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:13 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:13 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:13 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:13 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:13 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:13 — with GitHub Actions Inactive
@harsh62 harsh62 temporarily deployed to IntegrationTest July 23, 2025 20:13 — with GitHub Actions Inactive
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.55%. Comparing base (e3d6f63) to head (2856e5a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4025      +/-   ##
==========================================
+ Coverage   67.51%   67.55%   +0.03%     
==========================================
  Files        1130     1130              
  Lines       52639    52639              
==========================================
+ Hits        35539    35560      +21     
+ Misses      17100    17079      -21     
Flag Coverage Δ
API_plugin_unit_test 70.33% <ø> (-0.03%) ⬇️
AWSPluginsCore 69.26% <ø> (ø)
Amplify 47.84% <ø> (+0.02%) ⬆️
Analytics_plugin_unit_test 85.20% <ø> (ø)
Auth_plugin_unit_test 73.64% <100.00%> (+0.08%) ⬆️
DataStore_plugin_unit_test 83.38% <ø> (+0.06%) ⬆️
Geo_plugin_unit_test 74.86% <ø> (ø)
Logging_plugin_unit_test 63.53% <100.00%> (ø)
Predictions_plugin_unit_test 34.77% <ø> (ø)
PushNotifications_plugin_unit_test 88.43% <ø> (ø)
Storage_plugin_unit_test 76.87% <100.00%> (ø)
unit_tests 67.55% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harsh62 harsh62 merged commit 97ba904 into main Jul 25, 2025
269 of 278 checks passed
@harsh62 harsh62 deleted the harsh62-patch-1 branch July 25, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants