fix(auth): allow removing and adding identity pool for an already deployed app #4022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4022 +/- ##
=======================================
Coverage 67.53% 67.54%
=======================================
Files 1130 1130
Lines 52620 52639 +19
=======================================
+ Hits 35539 35553 +14
- Misses 17081 17086 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thisisabhash
approved these changes
Jul 16, 2025
| @@ -57,6 +57,14 @@ struct UserPoolConfigurationData: Equatable { | |||
| func getIdentityProviderName() -> String { | |||
| return "cognito-idp.\(region).amazonaws.com/\(poolId)" | |||
| } | |||
|
|
|||
| static func isNamespacingEqual( | |||
There was a problem hiding this comment.
probably good to have a test for this method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#4008
This pull request enhances the migration logic for AWS Cognito credential storage in the
AWSCognitoAuthCredentialStoreand introduces a helper method inUserPoolConfigurationDatato compare user pool configurations. The changes aim to ensure smoother transitions between old and new configurations during migrations.Credential Migration Enhancements:
Description
General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.