Adding cypress data-test attributes, add a spread props for the toast component and match text across components #3252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y UI Components React
Cypress data attributes for Sumerian Scene
…with similar components
…name spacing already being used, adjusted data test attrs in react angular to match vue
ghost
added
the
|
close to clean up commits #3253 |
This was referenced Dec 23, 2020
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Removed Cypress from amplify-js as it will be used in another repo, added data-test attributes in order to utilize best practices of Cypress, adjusted the Toast component to accept a props spread in order to add an error data test attribute for cypress and ended up adjusting naming of fields within the authentication workflow to be consistent across frameworks.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.