Skip to content

chore: Added more XR deprecation warnings #10977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

jimblanc
Copy link
Contributor

Description of changes

Adds some more XR deprecation warnings to the Sumerian provider & class.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jimblanc jimblanc marked this pull request as ready for review February 16, 2023 00:03
@jimblanc jimblanc requested a review from a team as a code owner February 16, 2023 00:03
@codecov-commenter
Copy link

Codecov Report

Merging #10977 (6522424) into main (d3bc119) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main   #10977   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files         198      198           
  Lines       19609    19609           
  Branches     4227     4227           
=======================================
  Hits        15996    15996           
  Misses       3323     3323           
  Partials      290      290           
Impacted Files Coverage Δ
packages/xr/src/Providers/SumerianProvider.ts 46.35% <ø> (ø)
packages/xr/src/XR.ts 68.60% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jimblanc jimblanc merged commit df016d0 into aws-amplify:main Feb 16, 2023
@jimblanc jimblanc deleted the chore/xr-messaging branch February 16, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants