Skip to content

feat(data): add Microsoft Edge testing; update WebKit Docker image #10917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 10, 2023

Conversation

david-mcafee
Copy link
Contributor

@david-mcafee david-mcafee commented Feb 1, 2023

Description of changes

Our Cypress image needed to be upgraded in order to support Microsoft Edge browser testing. This new image caused several E2E tests to break - this is because the manual process we were using for setting the network status is no longer supported.
To remediate this, I utilized the Reachability component's helper function for setting the network status.
However, there were a few Auth and PubSub tests that still failed to work after the upgrade, despite attempting to remediate with the Reachability component.
As a workaround, these tests will continue to use the old Cypress image. I've added TODOs in both the CCI config, as well as the tests themselves, and added an item to the JS backlog to address this issue.

Successful test run.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • [ N/A ] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@david-mcafee david-mcafee force-pushed the edge-testing-2 branch 13 times, most recently from 72e0277 to 0647235 Compare February 2, 2023 01:36
@david-mcafee david-mcafee changed the title feat(data): add Microsoft Edge testing feat(data): add Microsoft Edge testing; update WebKit Docker image Feb 2, 2023
@david-mcafee david-mcafee force-pushed the edge-testing-2 branch 4 times, most recently from e802ca6 to 564a95a Compare February 2, 2023 02:17
@david-mcafee david-mcafee requested review from a team, iartemiev, svidgen and stocaaro February 2, 2023 02:29
@david-mcafee david-mcafee force-pushed the edge-testing-2 branch 8 times, most recently from 24828b4 to 1231211 Compare February 3, 2023 19:34
@david-mcafee david-mcafee requested a review from a team as a code owner February 3, 2023 21:58
Copy link
Member

@svidgen svidgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in draft form until the samples PR is merged and TODO's + testing cruft are cleaned up here?

@david-mcafee
Copy link
Contributor Author

Should this be in draft form until the samples PR is merged and TODO's + testing cruft are cleaned up here?

I explain more in the description, but the TODOs are not to be addressed in this PR - I've added an item to the JS backlog for them. As far as marking as a draft, I figured I'd have folks review this PR alongside the samples repo PR as a whole. If you think that going forward we should not do this, happy to discuss :)

@@ -1553,10 +1576,14 @@ releasable_branches: &releasable_branches
- 1.0-stable
- geo/main
- in-app-messaging/main
- edge-testing-2

test_browsers: &test_browsers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is not longer a single list of test browsers, and this isn't "all" test browsers, what is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently discussing naming with the JS team offline. I've updated this with better documentation, as well as a better naming convention. However, I'm open to suggestions :)

@svidgen
Copy link
Member

svidgen commented Feb 9, 2023

Should this be in draft form until the samples PR is merged and TODO's + testing cruft are cleaned up here?

I explain more in the description, but the TODOs are not to be addressed in this PR - I've added an item to the JS backlog for them. As far as marking as a draft, I figured I'd have folks review this PR alongside the samples repo PR as a whole. If you think that going forward we should not do this, happy to discuss :)

Gotcha. The one that always catches my eye is the git checkout <some-samples-branch>. And in this one, a publish command has been commented out. I assume those are testing artifacts that should be undone? Or, am I missing something? 😅

@david-mcafee
Copy link
Contributor Author

Should this be in draft form until the samples PR is merged and TODO's + testing cruft are cleaned up here?

I explain more in the description, but the TODOs are not to be addressed in this PR - I've added an item to the JS backlog for them. As far as marking as a draft, I figured I'd have folks review this PR alongside the samples repo PR as a whole. If you think that going forward we should not do this, happy to discuss :)

Gotcha. The one that always catches my eye is the git checkout <some-samples-branch>. And in this one, a publish command has been commented out. I assume those are testing artifacts that should be undone? Or, am I missing something? 😅

No, you're correct, I somehow forgot to remove this. Sorry for the confusion!

erinleigh90
erinleigh90 previously approved these changes Feb 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #10917 (a56569a) into main (8f6dd70) will decrease coverage by 4.07%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #10917      +/-   ##
==========================================
- Coverage   85.65%   81.59%   -4.07%     
==========================================
  Files         196      198       +2     
  Lines       18261    19609    +1348     
  Branches     3892     4232     +340     
==========================================
+ Hits        15642    15999     +357     
- Misses       2543     3319     +776     
- Partials       76      291     +215     
Impacted Files Coverage Δ
...ackages/pubsub/src/Providers/AWSAppSyncProvider.ts 15.38% <0.00%> (-52.75%) ⬇️
packages/datastore/src/predicates/index.ts 88.61% <0.00%> (-7.32%) ⬇️
packages/amazon-cognito-identity-js/src/Client.js 50.48% <0.00%> (-1.52%) ⬇️
...ackages/pubsub/src/Providers/MqttOverWSProvider.ts 91.53% <0.00%> (-1.06%) ⬇️
packages/pubsub/src/PubSub.ts 92.42% <0.00%> (-0.64%) ⬇️
packages/xr/src/Providers/SumerianProvider.ts 46.35% <0.00%> (-0.59%) ⬇️
packages/datastore/__tests__/commonAdapterTests.ts 98.20% <0.00%> (-0.13%) ⬇️
...ages/amazon-cognito-identity-js/src/CognitoUser.js 79.06% <0.00%> (-0.12%) ⬇️
packages/datastore/src/predicates/next.ts 94.63% <0.00%> (-0.04%) ⬇️
packages/xr/src/XR.ts 68.60% <0.00%> (ø)
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@david-mcafee david-mcafee requested review from svidgen, erinleigh90 and a team February 10, 2023 04:49
Copy link
Member

@svidgen svidgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants