-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(data): add Microsoft Edge testing; update WebKit Docker image #10917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
72e0277
to
0647235
Compare
e802ca6
to
564a95a
Compare
24828b4
to
1231211
Compare
1231211
to
d6f0a46
Compare
d6f0a46
to
89e7418
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in draft form until the samples PR is merged and TODO's + testing cruft are cleaned up here?
1d3ffc1
to
eabb950
Compare
eabb950
to
5c34e17
Compare
I explain more in the description, but the TODOs are not to be addressed in this PR - I've added an item to the JS backlog for them. As far as marking as a draft, I figured I'd have folks review this PR alongside the samples repo PR as a whole. If you think that going forward we should not do this, happy to discuss :) |
.circleci/config.yml
Outdated
@@ -1553,10 +1576,14 @@ releasable_branches: &releasable_branches | |||
- 1.0-stable | |||
- geo/main | |||
- in-app-messaging/main | |||
- edge-testing-2 | |||
|
|||
test_browsers: &test_browsers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is not longer a single list of test browsers, and this isn't "all" test browsers, what is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently discussing naming with the JS team offline. I've updated this with better documentation, as well as a better naming convention. However, I'm open to suggestions :)
Gotcha. The one that always catches my eye is the |
No, you're correct, I somehow forgot to remove this. Sorry for the confusion! |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #10917 +/- ##
==========================================
- Coverage 85.65% 81.59% -4.07%
==========================================
Files 196 198 +2
Lines 18261 19609 +1348
Branches 3892 4232 +340
==========================================
+ Hits 15642 15999 +357
- Misses 2543 3319 +776
- Partials 76 291 +215
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Description of changes
Our Cypress image needed to be upgraded in order to support Microsoft Edge browser testing. This new image caused several E2E tests to break - this is because the manual process we were using for setting the network status is no longer supported.
To remediate this, I utilized the Reachability component's helper function for setting the network status.
However, there were a few Auth and PubSub tests that still failed to work after the upgrade, despite attempting to remediate with the Reachability component.
As a workaround, these tests will continue to use the old Cypress image. I've added TODOs in both the CCI config, as well as the tests themselves, and added an item to the JS backlog to address this issue.
Successful test run.
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.