fix: OIDC Parallel Requests error #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lou1415926
reviewed
Jan 11, 2022
paragbhingre
force-pushed
the
OIDCParallelRequest
branch
from
4e77a1b to
133757e
Compare
Lou1415926
approved these changes
Jan 12, 2022
GrahamCampbell
approved these changes
Jan 13, 2022
facebook-github-bot
pushed a commit
to pytorch/torchx
that referenced
this pull request
Feb 11, 2022
Summary: Our integration tests are hitting an error when acquiring AWS credentials. ``` botocore.errorfactory.InvalidIdentityTokenException: An error occurred (InvalidIdentityToken) when calling the AssumeRoleWithWebIdentity operation: Couldn't retrieve verification key from your identity provider, please reference AssumeRoleWithWebIdentity documentation for requirements ``` https://github.com/pytorch/torchx/runs/5147711223?check_suite_focus=true This switches to the `aws-actions/configure-aws-credentials` GitHub action since it includes retries as of aws-actions/configure-aws-credentials#350 Pull Request resolved: #386 Test Plan: CI Reviewed By: kiukchung Differential Revision: D34158910 Pulled By: d4l3k fbshipit-source-id: 6b6b9516b0233ea5b0f05f0fc5e6483829587c82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #299
Description - When multiple workflows try to assume a role at the same time then OIDC provider returns an error -
Couldn't retrieve verification key from your identity provider, please reference AssumeRoleWithWebIdentity documentation for requirementsWe now have a fix which will make sure that these parallel requests will retry assuming a role if it fails to do so.
retryAndBackofflogic will take care of retrial of assuming a role at random times so that no 2 parallel requests will try to get credentials from OIDC provider at the same time.Screenshots -
We have tried running 40 parallel workflows and all of them were able to assume a role successfully