toplevel: Parallelize report_package signature analysis
#785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #785 +/- ##
==========================================
+ Coverage 83.87% 83.92% +0.04%
==========================================
Files 12 12
Lines 3033 3067 +34
==========================================
+ Hits 2544 2574 +30
- Misses 489 493 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Parallelize the analysis of method signatures in `report_package` using `Threads.@spawn`. Each `analyze_method_signature!` task gets its own independent `AnalyzerState` with local `inf_cache` and `analysis_results`, avoiding data races without complex cross-task cache sharing. Design notes: https://publish.obsidian.md/jetls/work/JETLS/JET/JET+Make+%60report_package%60+parallelized Key changes: - Add `AtomicContainers` module providing thread-safe container types (`SWContainer`, `LWContainer`, `CASContainer`) for concurrent access - Introduce `CASDict` for thread-safe analyzer cache (`JET_ANALYZER_CACHE` and `OPT_ANALYZER_CACHE`) - Add `PackageAnalysisProgress` struct for tracking parallel analysis progress with atomic counters - Parallelize `analyze_from_definitions!` in virtualprocess.jl Benchamrks: > `julia --startup-file-no --threads=4,2 -e 'using JET; report_package(JET; target_modules=(JET,), sourceinfo=:compact);'` | Approach | Time | |------------|--------| | sequential | 52.07s | | parallel | 17.75s | > ``julia --startup-file=no --threads=4,2 -e 'using JET; using Pkg; Pkg.activate(; temp=true); Pkg.add("CSV"); using CSV; report_package(CSV; target_modules=(CSV,), sourceinfo=:compact);'`` | Approach | Time | |------------|--------| | sequential | 44.23s | | parallel | 19.57s | Written by Claude
aviatesk
force-pushed
the
avi/multithreading
branch
from
b41a606 to
3cb0a83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallelize the analysis of method signatures in
report_packageusingThreads.@spawn. Eachanalyze_method_signature!task gets its own independentAnalyzerStatewith localinf_cacheandanalysis_results, avoiding data races without complex cross-task cache sharing.Design notes: https://publish.obsidian.md/jetls/work/JETLS/JET/JET+Make+%60report_package%60+parallelized
Key changes:
AtomicContainersmodule providing thread-safe container types (SWContainer,LWContainer,CASContainer) for concurrent accessCASDictfor thread-safe analyzer cache (JET_ANALYZER_CACHEandOPT_ANALYZER_CACHE)PackageAnalysisProgressstruct for tracking parallel analysis progress with atomic countersanalyze_from_definitions!in virtualprocess.jlBenchmarks: