Fix ACL glob matching to support multi-wildcard patterns#50
Merged
Conversation
Patterns like `*admin*` or `sentry__*_admin__*` silently failed because glob_match only handled single prefix/suffix wildcards. The ACL would match nothing for these patterns, effectively making them useless. Rewrite glob_match to split on `*` and match segments sequentially, supporting any number of wildcards anywhere in the pattern. Update docs to cover the full glob syntax and fix the outdated "Output: JSON everywhere" section in architecture.md. fixed: #49 Signed-off-by: Avelino <31996+avelino@users.noreply.github.com>
Signed-off-by: Avelino <31996+avelino@users.noreply.github.com>
Signed-off-by: Avelino <31996+avelino@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patterns like
*admin*orsentry__*_admin__*silently failed because glob_match only handled single prefix/suffix wildcards. The ACL would match nothing for these patterns, effectively making them useless.Rewrite glob_match to split on
*and match segments sequentially, supporting any number of wildcards anywhere in the pattern. Update docs to cover the full glob syntax and fix the outdated "Output: JSON everywhere" section in architecture.md.fixed: #49